fix: reject -f flag combined with a resource kind on create - #430
Merged
Conversation
thde
changed the title
thde
reviewed
Jul 14, 2026
thde
approved these changes
Jul 15, 2026
Contributor
Author
|
ticket: 1695 |
…nd apply subcommands Defined -f on the file-based subcommand instead of the parent struct so kind subcommands no longer inherit it. switched the file subcommands default from "1" to "withargs" so its still picked automatically when no kind is given.
SaadAssaf
force-pushed
the
nctl_file_flagCheck_parentFix
branch
from
July 15, 2026 11:48
01c5364 to
901e4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-fis now only allowed when doingnctl create -fasnctl create <type> -fdoesn't make any sense. A file already contains the types of its resources.